Repository navigation
Add JS::True and JS::False - #248
Merged
Merged
Conversation
To treat the return value of a JavaScript function as a condition of a Ruby if expression, do the following
if searchParams.has('phrase') == JS::True`.
ledsun
commented
Jul 24, 2023
| assert_equal 'null', JS::Null.to_s | ||
| assert_equal 'undefined', JS::Undefined.to_s | ||
| assert_equal 'true', JS::True.to_s | ||
| assert_equal 'false', JS::False.to_s |
Contributor
Author
There was a problem hiding this comment.
If I use JS::Object with assert_equal as the argument, I get the following error:
JS::Error: TypeError: Cannot read properties of null (reading 'encoding')
To avoid the error, I compare with a string.
kateinoigakukun
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request where I switched from implementing the to_b method to implementing JS::True, as pointed out in #247.
The following use cases are assumed:
It is used to correctly determine the boolean value returned from a JavaScript function in a Ruby if expression.