Repository navigation
Add boolean conversion to ? suffixed predicate method - #258
Merged
Merged
Conversation
To avoid conflicts with other gems installed in the same Ruby package
kateinoigakukun
force-pushed
the
katei/js-predicate-method
branch
from
July 24, 2023 08:02
520ada6 to
c1e2afd
Compare
kateinoigakukun
marked this pull request as ready for review
July 24, 2023 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature satisfies the scenario shown in #247 in a Ruby way. The form of the shorthand looks much Rubyish and smarter than
== JS::True, also it brings minimum complexity.e.g.
This idea itself is suggested by @znz. Thanks!