Repository navigation
Conversation
avail_in is a uInt, and the input past the first UINT_MAX bytes was discarded. Zlib::Deflate.deflate and Zlib::GzipWriter#write silently lost the tail of a longer input, and Zlib::Inflate.inflate raised Zlib::BufError on longer compressed input. src = "a" * (2**32 + 1) Zlib::Inflate.inflate(Zlib::Deflate.deflate(src)).bytesize # expected: 4294967297 # actual: 4294967295 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zlib::Deflate.deflateandZlib::GzipWriter#writesilently drop everything after the first 4GiB - 1 bytes of their input, andZlib::Inflate.inflateraisesZlib::BufErroron compressed input of that size.avail_inis auInt, and the zstream gave zlib only that much and discarded the rest.The rest is now handed to zlib as
avail_inruns out, and the flush mode is passed only with the last part, soZ_FINISHno longer ends the stream early.I didn't add a test because it needs over 12GiB of memory. I checked
Zlib::Deflate.deflate,Zlib.gzipandZlib::Inflate.inflatewith 4GiB + 1MiB of input on x64-mswin64_140 (ruby 4.1.0dev 3a55e5c6d3), and all three round-trip with this change.Generated with Claude Code