Repository navigation
Conversation
Called from the block of Zlib::Inflate#inflate, #sync pointed next_in at its argument, and the inflate loop kept reading from there after the block returned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It described the return values the other way around, and did not mention Zlib::InProgressError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zlib::Inflate#syncdid not check whether the stream was in progress. Called from the block ofZlib::Inflate#inflate, it pointednext_inat its argument, and the inflate loop kept reading from there after the block returned, even after the argument was freed.It now raises
Zlib::InProgressError, as#<<and#finishalready do there. The last chunk is yielded after the loop has returned, so#syncfrom that yield keeps working.I also fixed the rdoc of
#sync, which described the return values the other way around.Generated with Claude Code