Repository navigation
Conversation
rwstauner
marked this pull request as ready for review
October 19, 2026 18:47
Member
|
Wow, that's a lot of changes. Any reason why we didn't cherry-pick the ones we are interested in? |
Contributor
Author
|
We certainly could if that's preferred. Usually we want the backports (they tend to be other useful fixes), though in this case there are a lot that are unrelated (win32, ci, etc). |
paracycle
approved these changes
Oct 19, 2026
k0kubun
approved these changes
Oct 19, 2026
rwstauner
force-pushed
the
rwstauner/407p3
branch
from
October 23, 2026 01:06
8f128f3 to
9c8dd0b
Compare
Member
|
Do we want to just move to v4.0.9? Is there any backports here not in v4.0.9? |
Contributor
Author
Yeah I think so. We just need to start a new 4.0.9-pshopify1 with those extra commits that weren't actually backports. |
Contributor
Author
|
4.0.9 with the extra commits we've been carrying: #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shopify/ruby@v4.0.7-pshopify2...Shopify:v4.0.7-pshopify3