Skip to content

Create 4.0.9-pshopify1 by merging backports branch into 4.0.7-pshopify2 - #96

Draft
rwstauner wants to merge 1 commit into
mainfrom
rwstauner/409p1
Draft

Create 4.0.9-pshopify1 by merging backports branch into 4.0.7-pshopify2#96
rwstauner wants to merge 1 commit into
mainfrom
rwstauner/409p1

Conversation

@rwstauner

@rwstauner rwstauner commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

replaces #93

@rwstauner
rwstauner marked this pull request as ready for review October 23, 2026 16:34
@rwstauner
rwstauner requested a review from a team as a code owner October 23, 2026 16:34
@rwstauner rwstauner mentioned this pull request Oct 23, 2026
Closed
@rwstauner rwstauner changed the title Merge backports branch into 4.0.7-pshopify2 to create 4.0.9-pshopify1 Create 4.0.9-pshopify1 by merging backports branch into 4.0.7-pshopify2 Oct 23, 2026
@k0kubun

k0kubun commented Oct 23, 2026

Copy link
Copy Markdown
Member

Is the CI crash relevant to our backports?

@luke-gruber

luke-gruber commented Oct 23, 2026

Copy link
Copy Markdown

@k0kubun We've seen this before, I don't think it's an indication of a regression.

@k0kubun

k0kubun commented Oct 23, 2026

Copy link
Copy Markdown
Member

I see, I think it's safe to migrate our current version to this one then. I was more worried about whether it's something reproducible in ruby_4_0 alone or only in ruby-definitions, and are you saying you saw it on ruby/ruby?

@rwstauner

rwstauner commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

There's a very similar crash that sometimes happens testing 4.0.7-pshopify1:
https://github.com/Shopify/ruby-definitions/actions/runs/39712449999/job/119606743588#step:7:278

So it might be something introduced by the non-official backports, or maybe those made it more likely, but sometimes CI passes fine:
https://github.com/Shopify/ruby-definitions/actions/runs/39876678354/job/120163881630

@rwstauner

rwstauner commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

benchmarks are showing 4.0.9-pshopify1 as slower than 4.0.9 across various benchmarks (not always the same ones).

two failed CI benchmarks:

My local linux machine is showing similar results.

@rwstauner
rwstauner marked this pull request as draft October 24, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwstauner @k0kubun @luke-gruber