Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186.
hostname_labels(allow_idn=False)draws uppercase letters, butidna.check_labelrejects them. The wasted samples make the existing ASCII-label and hostname tests fail Hypothesis'sfilter_too_muchhealth check.Draw lowercase ASCII letters instead. Uppercase labels could not get past validation before, so the set of returned labels stays the same. No health checks are disabled.
The unmodified code fails all three ASCII strategy tests with the seed from #186. After the change, all 135 tests and doctests pass on Python 3.9 with the pinned pytest 5.2.4/Hypothesis 5.8.6/idna 2.9 dependencies, and on Python 3.12 with Hypothesis 6.170.9 (two seeds). The prescribed Black 21.7b0, Flake8 3.9.2, and mypy 0.910 checks pass.