Skip to content

Avoid uppercase ASCII labels in hostname strategies #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aminark wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid uppercase ASCII labels in hostname strategies #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/hyperlink/hypothesis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
else:
from csv import reader as csv_reader
from os.path import dirname, join
from string import ascii_letters, digits
from string import ascii_lowercase, digits
from sys import maxunicode
from typing import (
Callable,
Expand Down Expand Up @@ -181,13 +181,14 @@ def hostname_labels(draw, allow_idn=True):
label = label[:-1]

else:
# IDNA's check_label rejects uppercase ASCII characters.
label = cast(
Text,
draw(
text(
min_size=1,
max_size=63,
alphabet=Text(ascii_letters + digits + u"-"),
alphabet=Text(ascii_lowercase + digits + u"-"),
)
),
)
Expand Down