Repository navigation
gh-160652: Make test_getoutput independent of the console code page - #160664
Open
summeriver13 wants to merge 1 commit into
Open
summeriver13 wants to merge 1 commit into
summeriver13 wants to merge 1 commit into
Conversation
…page The shell writes its error message in the console code page, which is not necessarily the encoding text mode picks (UTF-8 once UTF-8 mode is on). Only the exit status is checked here, so tolerate undecodable bytes instead of failing on them.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
aisk
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_getoutputfails on Windows whenever the console code page is not UTF-8:getstatusoutput()decodes the shell's localized error message as UTF-8 and raises.UTF-8 is correct for Python's side of the pipe — the code page is the child's choice, not Python's — but this test only needs the exit status, so let the decoder replace the bytes it cannot decode. That keeps
getstatusoutput()under test instead of switching torun(), as suggested in the issue.Verified on zh-CN Windows 11 (CP936), current main:
3.12 with
-X utf8=1fails the same way, so the test was encoding-dependent since UTF-8 mode existed; 3.15 only made it the default. Skip news (test only).AI assistance: drafted with deepseek-v4.1-flash in the pi coding agent; commands above were run locally, text reviewed by the author.
Fixes #160652