Skip to content

gh-160652: Make test_getoutput independent of the console code page #160664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
summeriver13 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

gh-160652: Make test_getoutput independent of the console code page #160664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4132,8 +4132,10 @@ def test_getoutput(self):
try:
dir = tempfile.mkdtemp()
name = os.path.join(dir, "foo")
# The message comes from the shell in the console code page,
# which need not be the encoding getstatusoutput() uses.
status, output = subprocess.getstatusoutput(
("type " if mswindows else "cat ") + name)
("type " if mswindows else "cat ") + name, errors="replace")
self.assertNotEqual(status, 0)
finally:
if dir is not None:
Expand Down
Loading